ever smoker

Usage notes

 * The hyphenated spelling ever-smoker is much more common when the noun is used attributively, to modify another noun, as in "ever-smoker males".